Skip to content

update comparisons in FAQ #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 5, 2021
Merged

update comparisons in FAQ #4307

merged 9 commits into from
Oct 5, 2021

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Oct 4, 2021

resolves #4123 #4289

@bpmct bpmct requested a review from a team as a code owner October 4, 2021 19:50
bpmct
bpmct commented Oct 4, 2021
View reviewed changes
jawnsy
jawnsy reviewed Oct 4, 2021
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 4, 2021 •
edited
Loading

✨ Coder.com for PR #4307 deployed! It will be updated on every commit.

@jsjoeio jsjoeio added the docs Documentation related label Oct 4, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Oct 4, 2021

Maybe your editor changed these files? Running yarn fmt locally will fix. Happy to help too!

image

jsjoeio
jsjoeio approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (minus the typos Jonathan pointed out + yarn fmt fix)

ashumz
ashumz reviewed Oct 5, 2021
View reviewed changes
ashumz
ashumz reviewed Oct 5, 2021
View reviewed changes
ashumz
ashumz reviewed Oct 5, 2021
View reviewed changes
ashumz
ashumz reviewed Oct 5, 2021
View reviewed changes
ashumz
ashumz reviewed Oct 5, 2021
View reviewed changes
GirlBossRush
GirlBossRush approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@GirlBossRush GirlBossRush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great addition to the our docs! At the moment I’m out of office for a medical procedure so I’ll defer to @jsjoeio and @code-asher.

bpmct and others added 6 commits October 5, 2021 11:31
@bpmct
Update docs/FAQ.md
70fbfc7 
Co-authored-by: Ashley McClelland <ashley@coder.com>
@bpmct
Update docs/FAQ.md
bb1799b 
Co-authored-by: Ashley McClelland <ashley@coder.com>
@bpmct
Update docs/FAQ.md
8745f1a 
Co-authored-by: Ashley McClelland <ashley@coder.com>
@bpmct
Update docs/FAQ.md
1af83a3 
Co-authored-by: Ashley McClelland <ashley@coder.com>
@bpmct
Update docs/FAQ.md
fa6f479 
Co-authored-by: Ashley McClelland <ashley@coder.com>
@bpmct
fix weird format
ee1de79
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #4307 (12ec117) into main (672038c) will increase coverage by 68.09%.
The diff coverage is 100.00%.

❗ Current head 12ec117 differs from pull request most recent head ee1de79. Consider uploading reports for the commit ee1de79 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           main    #4307       +/-   ##
=========================================
+ Coverage      0   68.09%   +68.09%     
=========================================
  Files         0       31       +31     
  Lines         0     1586     +1586     
  Branches      0      308      +308     
=========================================
+ Hits          0     1080     +1080     
- Misses        0      432      +432     
- Partials      0       74       +74
Impacted Files Coverage Δ
src/node/wrapper.ts 22.07% <ø> (ø)
src/node/routes/index.ts 76.53% <100.00%> (ø)
src/node/wsRouter.ts 91.66% <0.00%> (ø)
src/node/routes/logout.ts 50.00% <0.00%> (ø)
src/node/routes/domainProxy.ts 62.50% <0.00%> (ø)
src/node/routes/update.ts 77.77% <0.00%> (ø)
src/node/routes/pathProxy.ts 69.23% <0.00%> (ø)
src/common/util.ts 100.00% <0.00%> (ø)
src/node/routes/login.ts 70.90% <0.00%> (ø)
src/node/app.ts 97.91% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672038c...ee1de79. Read the comment docs.

@bpmct bpmct merged commit dfc505b into main Oct 5, 2021
@bpmct bpmct deleted the bpmct/comparison branch October 5, 2021 17:24
@jsjoeio jsjoeio mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@jawnsy jawnsy jawnsy left review comments

@ashumz ashumz ashumz left review comments

@GirlBossRush GirlBossRush GirlBossRush approved these changes

@jsjoeio jsjoeio jsjoeio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bpmct bpmct

Labels

docs Documentation related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notify users of new github web editor

5 participants

@bpmct @jsjoeio @jawnsy @ashumz @GirlBossRush